feat: highlighting flags chart #8237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Sep 24, 2024
| @@ -82,6 +82,11 @@ export const createBarChartOptions = ( | |||
| return { | |||
| plugins: { | |||
| legend: plugins?.legend, | |||
| // required to avoid the highlight plugin highlighting empty annotation | |||
| annotation: { | |||
There was a problem hiding this comment.
even though we don't use annotations on this chart it is used in the network data usage. ChartJs has global registrations so this page can be affected.
kwasniew
commented
Sep 24, 2024
| @@ -1,9 +1,8 @@ | |||
| import type { Chart } from 'chart.js'; | |||
|
|
|||
| export const customHighlightPlugin = { | |||
| export const customHighlightPlugin = (width = 46, bottomOverflow = 34) => ({ | |||
There was a problem hiding this comment.
defaults optimized for the network data usage where I took it from for reuse
thomasheartman
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adding highlighter shadow to each data point
I had to explicitly disable annotations highlighting since ChartJS has a global registry of plugins and the annotation plugin from the data network tab was doing this registration. As a result if you open network data usage and then go to your dashboard you'd get the entire chart highlighted from the invisible annotation.
Important files
Discussion points