Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group project roles to project roles #8245

Conversation

thomasheartman
Copy link
Contributor

This PR adds project roles you get from groups to the list of roles listed for each project.

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 8:12am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 8:12am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a similar query in the system where you get all the projects you have access to based on your role and group?

@thomasheartman
Copy link
Contributor Author

Summary from Slack: I don't think we have any queries that do this already. Both the project overview and the personal projects page just get the projects endpoint and then seem to do the filtering on the front end.

@thomasheartman thomasheartman merged commit 289324f into main Sep 25, 2024
12 of 13 checks passed
@thomasheartman thomasheartman deleted the feat/1-2892-include-roles-you-get-from-groups-in-project-roles branch September 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants