Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the projects? Property from ICreateGroupModel #8246

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Sep 25, 2024

This property does not seem to be used anywhere, so we can remove it.

Can't find any references in code here or in enterprise. Let's try it and see if it breaks.

This property does not seem to be used anywhere, so we can remove it.
I think.
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 8:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 8:22am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasheartman thomasheartman merged commit aa28b78 into main Oct 2, 2024
12 of 13 checks passed
@thomasheartman thomasheartman deleted the chore/remove-group-projects branch October 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants