feat: flag exposure in personal dashboard #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
thomasheartman
approved these changes
Sep 25, 2024
| loading={loading} | ||
| project={'default'} | ||
| > | ||
| <span>child</span> |
There was a problem hiding this comment.
curious: what is this child? is it just the text child in a span?
There was a problem hiding this comment.
this component accepts any ReactElement as children prop so wanted to specify sth that doesn't look like string. In tests we find this element by text so passing child without a span would also work
Comment on lines
+61
to
+68
| {feature.project ? ( | ||
| <MarkCompletedDialogue | ||
| isOpen={showMarkCompletedDialogue} | ||
| setIsOpen={setShowMarkCompletedDialogue} | ||
| projectId={feature.project} | ||
| featureId={feature.name} | ||
| onComplete={refetchFeature} | ||
| /> |
There was a problem hiding this comment.
Can a feature not have a project?
There was a problem hiding this comment.
Yes, a placeholder feature has an empty project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Show last seen widget and lifecycle widget when selecting a flag
Same last seen as the project flags and single flag view
Same lifecycle as the project flags and single flag view
Details:
Important files
Discussion points