feat: display new completed dialog #8255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjaanus
commented
Sep 25, 2024
sjaanus
commented
- Now the dialog will not close when SDK got connected
- It will start to show the suggested production code. ( this will be attached in next PR)
- Also, it has connected indicator on the right
- Back button is removed in this stage.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sjaanus
commented
Sep 25, 2024
| > | ||
| Back | ||
| </Button> | ||
| {!onboarded ? ( |
There was a problem hiding this comment.
Hide the back button when onboarded.
sjaanus
commented
Sep 25, 2024
| } | ||
| /> | ||
| </ConnectionStatus> | ||
| {onboarded ? ( |
There was a problem hiding this comment.
When onboarded, we have a new checkmark and text .
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
sjaanus
commented
Sep 25, 2024
| sdk: Sdk; | ||
| } | ||
|
|
||
| export const SdkConnected: FC<ISdkConnectedProps> = ({ sdk }) => { |
There was a problem hiding this comment.
This is the new sdk connected tab, that shows the production ready code. Some parts of code can be removed, when we have 3 layer markdown ready. In next PR.
Tymek
approved these changes
Sep 25, 2024
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tymoteusz Czech <[email protected]>
…Toggles/ProjectFeatureToggles.tsx Co-authored-by: Tymoteusz Czech <[email protected]>
Co-authored-by: Tymoteusz Czech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.