feat: get projects by ids #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
commented
Sep 26, 2024
| userId?: number, | ||
| ): Promise<ProjectForUi[]> { | ||
| const getProjects = () => |
thomasheartman
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adding ability to read projects by multiple ids.
Background:
In the personal dashboard we need to return a list of user projects with health/flags counts/members count (that a user is a member of or favorited). My plan is to have a separate query to read user project ids and then pass those ids to the existing query. This way we can orchestrate the desired behavior in a service without writing new complex queries.
Important files
Discussion points
I considered changing query param id to query param ids (plural) in place, but since we use the single id in a few places I find it safer to add a new property and not touch the existing code.