Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event timeline should unmount when hidden and be closed by default #8294

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

nunogois
Copy link
Member

Fixes 2 bugs:

  • The initial state of the event timeline should have open: false, not true - Closed by default, unless opened
  • The event timeline should unmount when hidden - It should not emit requests when closed

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 0:10am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@nunogois nunogois merged commit 81840ed into main Sep 27, 2024
13 checks passed
@nunogois nunogois deleted the fix-event-timeline-should-unmount branch September 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants