test: test the dashboard admins property #8303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Sep 30, 2024
kwasniew
reviewed
Sep 30, 2024
src/lib/features/personal-dashboard/personal-dashboard-controller.e2e.test.ts
Outdated
Show resolved
Hide resolved
kwasniew
reviewed
Sep 30, 2024
src/lib/features/personal-dashboard/personal-dashboard-controller.e2e.test.ts
Show resolved
Hide resolved
kwasniew
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the new admins property of the personal dashboard API payload.
It checks that only user admins are added and that their image URL is not an empty string. In doing this, also fixes an issue where the image URL wouldn't be generated correctly.
Discussion points
Some of the test feels like it might be better testing on a deeper level (i.e. the account store). However, from an initial glance, I think that would require more setup and work, so I'm leaving it in the dashboard test for now as that's where it's ultimately useful. But we can discuss if we should move it.