refactor: use promise.all instead of sequential awaited calls #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Oct 2, 2024
| id: role.id, | ||
| name: role.name, | ||
| type: role.type as PersonalDashboardProjectDetailsSchema['roles'][number]['type'], | ||
| const formatEvents = (recentEvents) => |
There was a problem hiding this comment.
is the recentEvents any typed?
There was a problem hiding this comment.
Probably implicitly so, yeah. I can see if I can add some types if you want
kwasniew
reviewed
Oct 2, 2024
| })); | ||
|
|
||
| const filterRoles = (allRoles) => |
There was a problem hiding this comment.
also seems to be any typed
kwasniew
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on a comment made in #8314 and groups sequential awaited calls into a single Promise.all instead.