Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health score components in personal dashboard #8348

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 3, 2024

About the changes

OSS users will always see this insight. Pro and Enterprise users will see this insights until they get 8 weeks of health trends data.
Screenshot 2024-10-03 at 09 57 45

Pro and Enterprise users will see this insight after they get 8 weeks of health trends data.
Screenshot 2024-10-03 at 09 57 56

Details:

  • reusing health chart and health chart legend from the project insights. I decided to include the legend so that we know what each color means

Important files

Discussion points

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:25am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 8:25am

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

gap: theme.spacing(1),
}));

export const FlagCounts: FC<{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is extracted from the project insights health widget so that we can compose is inside personal dashboard

totalFlags,
potentiallyStaleFlags,
staleFlags,
activeFlags: totalFlags - staleFlags - potentiallyStaleFlags,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also get the total flags in the payload? Any reason we calculate again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do get it in the personal dashboard global overview. This is the project details endpoint. Theoretically we could reuse the value from the global overview but this was just convenient. If we ever decide to re-use the project endpoint we get all the data in one go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in other words this change allows to move the project details around without thinking about the data source since it's self sufficient.

@kwasniew kwasniew merged commit 10dffcd into main Oct 3, 2024
6 of 8 checks passed
@kwasniew kwasniew deleted the health-score-component-personal-dashboard branch October 3, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants