-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: health score components in personal dashboard #8348
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
gap: theme.spacing(1), | ||
})); | ||
|
||
export const FlagCounts: FC<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code is extracted from the project insights health widget so that we can compose is inside personal dashboard
totalFlags, | ||
potentiallyStaleFlags, | ||
staleFlags, | ||
activeFlags: totalFlags - staleFlags - potentiallyStaleFlags, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also get the total flags in the payload? Any reason we calculate again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do get it in the personal dashboard global overview. This is the project details endpoint. Theoretically we could reuse the value from the global overview but this was just convenient. If we ever decide to re-use the project endpoint we get all the data in one go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in other words this change allows to move the project details around without thinking about the data source since it's self sufficient.
About the changes
OSS users will always see this insight. Pro and Enterprise users will see this insights until they get 8 weeks of health trends data.
Pro and Enterprise users will see this insight after they get 8 weeks of health trends data.
Details:
Important files
Discussion points