Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add event timeline to new in unleash #8358

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Oct 3, 2024

https://linear.app/unleash/issue/2-2729/add-event-timeline-to-new-in-unleash

Adds the new event timeline to the "New in Unleash" section.

Unlike Signals & Actions, the Event timeline doesn’t have a dedicated page to link to, as it's a global component within the layout. To address this, we extend the "check it out" action in the New in Unleash component by supporting a callback instead of a link. When the user clicks "check it out" for this new item, the page smoothly scrolls to the top, the timeline opens (if it's not already), and a temporary highlight effect is triggered on the timeline header button.

Also includes some scouting / slight UX adjustments.

unleash_event_timeline_highlight_button.mp4

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 3:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 3:09pm

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

behavior: 'smooth',
});
},
docsLink: 'https://docs.getunleash.io/reference/events',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melindafekete we may want to update this to a more event-timeline-specific documentation URL once it’s available.

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nunogois nunogois merged commit 52b7e23 into main Oct 4, 2024
11 checks passed
@nunogois nunogois deleted the chore-event-timeline-new-in-unleash branch October 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants