Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events docs revamp #8360

Merged
merged 15 commits into from
Oct 8, 2024
Merged

Events docs revamp #8360

merged 15 commits into from
Oct 8, 2024

Conversation

melindafekete
Copy link
Collaborator

@melindafekete melindafekete commented Oct 3, 2024 •
edited
Loading

About the changes

Merge events-related concept pages into one page. Add event timeline functionality

Preview link of Events

@melindafekete melindafekete self-assigned this Oct 3, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:29am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:29am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@melindafekete
Remove more examples
cf15804 
Fix broken link
@melindafekete
Highlight difference between event log and timeline
7bba5f0 
Extend description of event timeline
@melindafekete
Copy link
Collaborator Author

There are close to a 100 undocumented events, but I will tackle this as a separate task:

https://linear.app/unleash/issue/MAR-970/document-missing-events

melindafekete
melindafekete commented Oct 8, 2024
View reviewed changes
website/docs/feature-flag-tutorials/ios/examples.md Outdated Show resolved Hide resolved
website/docs/feature-flag-tutorials/python/examples.md Outdated Show resolved Hide resolved
website/docs/feature-flag-tutorials/react/examples.md Outdated Show resolved Hide resolved
website/docs/feature-flag-tutorials/react/examples.md Outdated Show resolved Hide resolved
website/docs/feature-flag-tutorials/ruby/ruby-examples.md Outdated Show resolved Hide resolved
website/docs/reference/events.mdx Show resolved Hide resolved
website/docs/reference/events.mdx Outdated Show resolved Hide resolved
website/docs/reference/events.mdx Outdated Show resolved Hide resolved
website/docs/reference/events.mdx Outdated Show resolved Hide resolved
website/docs/reference/events.mdx Show resolved Hide resolved
@melindafekete melindafekete changed the title [WIP] Events docs revamp Events docs revamp Oct 8, 2024
@melindafekete melindafekete marked this pull request as ready for review October 8, 2024 08:27
@melindafekete melindafekete requested a review from nunogois October 8, 2024 08:28
nunogois
nunogois approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Great job with this and thank you for the help!

@melindafekete melindafekete merged commit 8736d2a into main Oct 8, 2024
10 of 12 checks passed
@melindafekete melindafekete deleted the melinda/event-timeline branch October 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunogois nunogois nunogois approved these changes

@daveleek daveleek Awaiting requested review from daveleek

Assignees

@melindafekete melindafekete

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melindafekete @nunogois