Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fontend dev command to start in sandbox pro environment #8376

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Oct 7, 2024

Update development command

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 9:18am

@Tymek Tymek enabled auto-merge (squash) October 7, 2024 09:00
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@@ -14,7 +14,7 @@
"dev": "vite",
"start": "vite",
"start:prod": "vite build && vite preview",
"start:sandbox": "UNLEASH_API=https://sandbox.getunleash.io/ospro yarn run start",
"start:sandbox": "UNLEASH_API=https://sandbox.getunleash.io/ VITE_TEST_REDIRECT=true UNLEASH_BASE_PATH=/pro/ yarn run start",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this include /pro in UNLEASH_API? or does the proxy automatically append UNLEASH_BASE_PATH to UNLEASH_API?

Copy link
Member Author

@Tymek Tymek Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied what we have for enterprise sandbox, and that works

@Tymek Tymek requested a review from chriswk October 7, 2024 09:52
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tymek Tymek merged commit 802a50d into main Oct 22, 2024
13 checks passed
@Tymek Tymek deleted the fix/sandbox-pro-frontend-cmd branch October 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants