Restructure features documentation #8394
Conversation
# Conflicts: # README.md # website/docs/topics/a-b-testing.md
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
melindafekete
changed the title
Rework overview
Correct lifetime value
| @@ -291,7 +291,7 @@ Generated when you drop all existing tags as part of a configuration import. The | |||
|
|
|||
| #### `feature-potentially-stale-on` | |||
|
|
|||
| Generated when Unleash marks a feature flag as potentially stale due to exceeding the expected lifetime of its [feature flag type](/reference/feature-toggle-types). `preData` and `data` are null. | |||
| Generated when Unleash marks a feature flag as potentially stale due to exceeding the expected lifetime of its [feature flag type](/reference/feature-toggles#feature-flag-types). `preData` and `data` are null. | |||
There was a problem hiding this comment.
| Generated when Unleash marks a feature flag as potentially stale due to exceeding the expected lifetime of its [feature flag type](/reference/feature-toggles#feature-flag-types). `preData` and `data` are null. | |
| Generated when Unleash marks a feature flag as potentially stale due to exceeding the expected lifetime of its [feature flag type](/reference/feature-toggles#feature-flag-types). `preData` and `data` are `null`. |
There was a problem hiding this comment.
Why do you suggest code formatting for this? Given that it's an unrelated change, and there are many occurrences of it, let's tackle it separately
|
|
||
| ## Environment level variants | ||
|
|
||
| [Environment level variants](./feature-toggle-variants) are deprecated. Use strategy variants instead. |
There was a problem hiding this comment.
Do we have a deprecation notice on the old variants doc page?
| from: '/advanced/archived_toggles', | ||
| to: '/reference/archived-toggles', | ||
| to: '/reference/feature-toggles', |
There was a problem hiding this comment.
We should probably update all the relevant redirects to target the new page.
It'll be (I think):
from: ['/advanced/archived_toggles', '/reference/archived-toggles']
to: '/reference/feature-toggles'Also, don't we do this server-side now? 🤔
So this goes for this one and all the other deleted files (I noticed there's only two redirects here, but you've deleted at least 6 files)
There was a problem hiding this comment.
Ah, but I see you've also updated the vercel file, which should take care of it. In that case, are the changes here still necessary?
There was a problem hiding this comment.
Yes, I added the new redirects in Vercel, these are some legacy ones. I am not sure if these '/advanced' pages are still getting any traffic. Eventually, all redirects should be in Vercel, but I wanted to tackle this separately, as we might not need to move all of them.
We should probably update all the relevant redirects to target the new page.
I am pointing these legacy pages to the new page too, unless I am missing something 🤔
About the changes
Reorganize, update, and improve concepts documentation around feature flags.
This PR merges all feature flag-related concepts pages into a single page. This helps the discoverability of all closely related topics and helps tie together these concepts through explanations between the different sections.
Previously:
Are now all on:
Additionally, removed the deprecated Feature Flag Variants from the navigation, now only referenced at the bottom of the strategy variants page. Also, I removed the how to create a naming pattern guide, as it covers the same information as the concepts docs, and there is not enough specific content to fill a standalone guide.