Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new signal meta properties in event timeline #8421

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

nunogois
Copy link
Member

https://linear.app/unleash/issue/2-2796/better-signals-integration

Adds support to the following signal payload meta properties:

  • unleash_title
  • unleash_description
  • unleash_icon
  • unleash_variant

Follows a logic similar to what we currently have for banners. E.g. custom icon.

Call signal endpoints

image
image

View signals in event timeline

image
image

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:30pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 2:30pm

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool to me :P

@nunogois
Copy link
Member Author

118bd5a prefixes these properties with experimental_ so that they better represent our outlook on them.

@nunogois nunogois merged commit 7c5fab5 into main Oct 10, 2024
11 checks passed
@nunogois nunogois deleted the chore-event-timeline-signals-new-meta-properties branch October 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants