chore: wrapTimer function types

[gastonfournier]

This gives us better types for our wrapTimer function.

Maybe the type (args: any) => any could also be improved

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unleash-monorepo-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 14, 2024 1:28pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 14, 2024 1:28pm

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[nunogois]

I think this could be a simpler approach, where we type our parameters and rely on the implicit type instead of a declared one:

const wrapTimer = (
    eventBus: EventEmitter,
    eventType: string,
    args: Record<string, unknown> = {},
) => {
    const t = timer.new();
    return (data: unknown) => {
        eventBus.emit(eventType, { ...args, time: t() });
        return data;
    };
};

If you prefer to have a type declaration, I would do something like this:

type WrapTimerFunction = (
    eventBus: EventEmitter,
    eventType: string,
    args?: Record<string, unknown>,
) => (data: unknown) => unknown;

const wrapTimer: WrapTimerFunction = (eventBus, eventType, args = {}) => {
    const t = timer.new();
    return (data) => {
        eventBus.emit(eventType, { ...args, time: t() });
        return data;
    };
};

Or maybe type it like this, if you think it's simpler to read:

type WrapTimerFunctionCallback = (data: unknown) => unknown;

type WrapTimerFunction = (
    eventBus: EventEmitter,
    eventType: string,
    args?: Record<string, unknown>,
) => WrapTimerFunctionCallback;

[nunogois]

Since we're touching this file, I also think these comments are outdated.

[nunogois]

Nice!