Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: front end code pt II #8444

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Oct 14, 2024

This PR continues the refactoring of the front end code for dashboards.

The main points are:

  • Extracts the ActionBox component that we used in a lot of places. There were some minor differences between the various incarnations, so this also better aligns them.
  • Extract other components (AskOwnerToAddYouToTheirProject, YourAdmins)
  • Move the NeutralCircleContainer into SharedComponents
  • Delete the separate no content grid (this is now handled in projects instead)
  • extract my projects grid contents into a single function so that it's easier to understand what content you get for what states

Here's all the states side by side:
image

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 9:28am

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@thomasheartman thomasheartman changed the title [wip]: refactor front end code pt II refactor: front end code pt II Oct 15, 2024
@thomasheartman thomasheartman enabled auto-merge (squash) October 15, 2024 09:11
@thomasheartman thomasheartman merged commit e4cfb29 into main Oct 15, 2024
4 of 6 checks passed
@thomasheartman thomasheartman deleted the refactor/1-2961-refactor-front-end-code-pt2 branch October 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants