chore: scroll-related UX adjustments in the Unleash AI chat #8478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
requested review from
chriswk,
gastonfournier,
daveleek and
sighphyre
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
frontend/src/component/ai/AIChat.tsx
Outdated
| } | ||
|
|
||
| return () => { | ||
| if (target) { |
There was a problem hiding this comment.
Should this be like this? target will get a reference to the target and the function will just keep it referenced
Suggested change
| if (target) { | |
| if (chatEndRef.current) { |
There was a problem hiding this comment.
Good point! I simplified this to always use the ref: 8d473e1
| @@ -153,7 +180,7 @@ export const AIChat = () => { | |||
| minSize={{ width: '270px', height: '200px' }} | |||
| maxSize={{ width: '90vw', height: '90vh' }} | |||
| defaultSize={{ width: '320px', height: '450px' }} | |||
| onResize={scrollToEnd} | |||
| onResize={() => scrollToEnd({ onlyIfAtEnd: true })} | |||
There was a problem hiding this comment.
Should we always scroll to end when resizing? I mean if you scroll up on a conversation and then resize...
There was a problem hiding this comment.
That's why we have onlyIfAtEnd: true. This is actually an improvement on: #8456 (comment)
nunogois
deleted the
chore-unleash-ai-chat-scroll-related-ux-adjustments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2857/make-some-scroll-related-ux-adjustments-to-the-unleash-ai-chat
Introduces scroll-related UX enhancements to the Unleash AI chat, providing a smoother and more refined user experience.