fix: don't allow . or .. in feature url #8479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Tymek
commented
Oct 18, 2024
There was a problem hiding this comment.
this change applies to features, tags, projects, context fields and addons
Tymek
changed the title
...aginatedProjectFeatureToggles/ProjectFeatureTogglesHeader/hooks/useFeatureCreatedFeedback.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+17
to
+19
| encodeURIComponent(value) !== value || | ||
| value === '..' || | ||
| value === '.' |
There was a problem hiding this comment.
Yeh, this is good. Are there other cases we might have missed?
I checked the docs for this function, and there's also - _ ! ~ * ' ( ):
Do we want to allow them? I guess there's no harm in it because they don't break urls the same way. Sure, let's go.
Tymek
force-pushed
the
1-2986-some-invalid-flag-names-arent-caught-by-validation-eg
branch
from
639818b to
24789d2
Compare
thomasheartman
approved these changes
Oct 21, 2024
Tymek
deleted the
1-2986-some-invalid-flag-names-arent-caught-by-validation-eg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do some validation on flag names, but there's some cases that slip through. These are some cases that we should handle better.
With
..as a name, you can't go into the flag in Unleash and you can't activate any environments because the it is interpreted as "go up a level".