Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gitar] Cleaning up stale flag: displayTrafficDataUsage with value true #8481

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

gitar-bot[bot]
Copy link
Contributor

@gitar-bot gitar-bot bot commented Oct 18, 2024

Gitar


This automated PR was generated by Gitar. View docs.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:56am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:56am

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@daveleek
Copy link
Contributor

This looks good to me but I want to double check things before I approve it

currentPeriod,
endpointsInfo,
]);
}, [true, includedTraffic, traffic, currentPeriod, endpointsInfo]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha took me a while to see this one. can probably remove the 'true' here xD

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveleek daveleek merged commit 589d9f1 into main Oct 24, 2024
14 checks passed
@daveleek daveleek deleted the gitar_displayTrafficDataUsage_true branch October 24, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant