chore: Prometheus metrics refactor #8484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
gastonfournier
commented
Oct 18, 2024
src/lib/metrics-gauge.ts
Outdated
Comment on lines
40
to
60
| private async fetch<T, L extends string>( | ||
| definition: GaugeDefinition<T, L>, | ||
| ): Promise<MetricValue<L>[]> { | ||
| const result = await definition.query(); | ||
| if ( | ||
| result !== undefined && | ||
| result !== null && | ||
| (!Array.isArray(result) || result.length > 0) | ||
| ) { | ||
| const resultArray = this.asArray(definition.map(result)); | ||
| resultArray | ||
| .filter((r) => !Number.isInteger(r.value)) | ||
| .forEach((r) => { | ||
| this.log.warn( | ||
| `Invalid value for ${definition.name}: ${r.value}. Value must be an integer.`, | ||
| ); | ||
| }); | ||
| return resultArray.filter((r) => Number.isInteger(r.value)); | ||
| } | ||
| return []; | ||
| } |
There was a problem hiding this comment.
Encapsulate transformation from the query result (which can either be a single result or an array), into an array of valid metrics for prometheus
gastonfournier
commented
Oct 18, 2024
| @@ -14,7 +14,7 @@ type MapResult<R, L extends string> = ( | |||
| type GaugeDefinition<T, L extends string> = { | |||
| name: string; | |||
| help: string; | |||
| labelNames: L[]; | |||
| labelNames?: L[]; | |||
There was a problem hiding this comment.
Support gauges without labels
gastonfournier
force-pushed
the
prometheus-metrics-refactor
branch
from
03149bd to
c458033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate some prometheus metrics to use the new and sequential metric updater