Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and restructure environments #8496

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Update and restructure environments #8496

merged 4 commits into from
Oct 22, 2024

Conversation

melindafekete
Copy link
Collaborator

@melindafekete melindafekete commented Oct 21, 2024 •
edited
Loading

About the changes

Update and restructure Environments documentation. The main changes are:

  • Environments concepts page:
    • Updated and restructured content and applied writing style changes
    • Added more explanations and use cases
    • Added more links to other related concepts
    • Removed the outdated Loom video from Ivar
    • Removed outdated sections (how to 'start' using environments, and migration)
    • Removed screenshots and used a better-fitting diagram to illustrate strategies and environments
    • Removed the list of events, as these are well documented on the events page
  • Removed the How to clone environments guide. This content is explained on the concepts page, and I felt there was not enough content to fill a standalone guide for this.

Preview link of the updated Environments page.

@melindafekete melindafekete self-assigned this Oct 21, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:03pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:03pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@melindafekete melindafekete marked this pull request as ready for review October 22, 2024 09:53
FredrikOseberg
FredrikOseberg approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, I've added some optional comments you can choose whether or not to address before merging.

website/docs/reference/environments.md Outdated Show resolved Hide resolved
website/docs/reference/environments.md Outdated Show resolved Hide resolved
@melindafekete melindafekete merged commit 8b0af59 into main Oct 22, 2024
14 checks passed
@melindafekete melindafekete deleted the melinda/environments-docs branch October 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

Assignees

@melindafekete melindafekete

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melindafekete @FredrikOseberg