feat: rework application overview db query #8518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
sjaanus
commented
Oct 23, 2024
| @@ -313,29 +313,40 @@ export default class ClientApplicationsStore | |||
| ), | |||
| ]) | |||
| .from('client_metrics_env as cme') | |||
| .where('cme.app_name', appName) | |||
There was a problem hiding this comment.
Extra where clause to reduce query scope
sjaanus
commented
Oct 23, 2024
| qb.select([ | ||
| 'ci.app_name', | ||
| 'ci.environment', | ||
| this.db.raw( |
There was a problem hiding this comment.
Now we count in database level, instead of joining and returning all.
sjaanus
commented
Oct 23, 2024
| this.db.raw( | ||
| 'COUNT(DISTINCT ci.instance_id) as unique_instance_count', | ||
| ), | ||
| this.db.raw( |
There was a problem hiding this comment.
We also count these in database.
sjaanus
commented
Oct 23, 2024
| this.db.raw( | ||
| 'ARRAY_AGG(DISTINCT ci.sdk_version) as sdk_versions', | ||
| ), | ||
| this.db.raw('MAX(ci.last_seen) as latest_last_seen'), |
There was a problem hiding this comment.
Also last seen, max will be taken, instead of doing it in memory.
sjaanus
commented
Oct 23, 2024
| @@ -397,25 +405,14 @@ export default class ClientApplicationsStore | |||
| }; | |||
| acc.push(env); | |||
| } else { | |||
| if (instance_id) { | |||
There was a problem hiding this comment.
Got rid of all of this logic done in memory
gastonfournier
approved these changes
Oct 23, 2024
| .orderBy('m.environment', 'asc'); | ||
| console.log(query.toQuery()); |
There was a problem hiding this comment.
Suggested change
| console.log(query.toQuery()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were returning all instance names from database, but now we count them in database.