Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stretch strategies underlying root cause #8520

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 23, 2024

About the changes

Parent element with display: block and justify-items: center was centering child div in Chrome. Same settings were stretching content in Firefox (to 100%) as if justify-items didn't exist. Since justify-items doesn't make sense for non flex layouts this PR removes it. Also we don't need artificial width: 100% on the child element.

Important files

Discussion points

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 1:40pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 1:40pm

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@kwasniew kwasniew merged commit b7b5a8a into main Oct 23, 2024
13 checks passed
@kwasniew kwasniew deleted the stretch-strategies-proper-fix branch October 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant