Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archived features can be searched now #8568

Merged
merged 7 commits into from
Oct 29, 2024
Merged

feat: archived features can be searched now #8568

merged 7 commits into from
Oct 29, 2024

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Oct 29, 2024

Archived features can be searched now.
This is the backend and small parts of frontend preparing to add filters, buttons etc in next PR.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend 🛑 Canceled (Inspect) Oct 29, 2024 9:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 9:27am

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

name: 'archived',
schema: {
type: 'string',
example: 'true',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we passing a string here instead of a boolean? I see we're doing it for the others too, but what's the reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using filters it will consist of operator and value. Like IS:archived.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ... is it IS:true? In that case, the example's wrong, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Does this also apply to the other query param examples in this file? That is, should we update them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think others have it correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all have IS, for example favorites doesnt and order etc.

src/lib/openapi/spec/feature-search-query-parameters.ts Outdated Show resolved Hide resolved
@sjaanus sjaanus merged commit 28e062b into main Oct 29, 2024
12 checks passed
@sjaanus sjaanus deleted the archived-in-table branch October 29, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants