feat: traffic limits for enterprise-payg #8596
Merged
+110
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
force-pushed
the
cto-82-unleash-update-unleash-to-only-show-53m-included-requests
branch
from
6dadd69 to
f6ab56a
Compare
nunogois
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Looks like a clean approach!
Shouldn't we add the feature flag in experimental.ts as well?
Since it's still just being introduced, maybe we can rename it to camelCase so it's consistent with our other flags, i.e. enterprisePAYG instead of enterprise-payg. It's also a bit detached from enterprise in its implementation, even though that's only a detail, but perhaps we could name it something more generic like paygBilling or something. WDYT?
Tymek
deleted the
cto-82-unleash-update-unleash-to-only-show-53m-included-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes