feat: activity widget #8628
Merged
feat: activity widget #8628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sjaanus
commented
Nov 5, 2024
|
|
||
| type Output = { date: string; count: number; level: number }; | ||
|
|
||
| export function transformData(inputData: ProjectActivitySchema): Output[] { |
There was a problem hiding this comment.
This can be cleaned up later, but basically for each day we need a level(color), and this divides them evenly into level buckets.
thomasheartman
approved these changes
Nov 5, 2024
|
|
||
| // Step 1: Count the occurrences of each date | ||
| inputData.forEach((item) => { | ||
| const formattedDate = new Date(item.date).toISOString().split('T')[0]; |
There was a problem hiding this comment.
Aren't they already formatted this way?
But anyway, this is just an accumulation, right? Assuming we have multiple entries for each date, it'll count each entry as one and sum them together?
Maybe I've misunderstood the API, but I thought we returned each date only once, with already summed up activities? In that case, this'd be wrong, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is still raw, next PRs add styling and date filtering for only single year.