Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unsubscribe link to user profile #8637

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 4, 2024

About the changes

Show link to user profile where she can manager email subscription

Important files

Discussion points

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 10:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:59am

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

src/lib/services/email-service.test.ts Outdated Show resolved Hide resolved
@@ -537,14 +537,11 @@ export class EmailService {
},
): Promise<IEmailEnvelope> {
if (this.configured()) {
const unsubscribeUrl = '{{amazonSESUnsubscribeUrl}}'; // FIXME: Add unsubscribe URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to also put unsubscripe url in headers. We need it on this level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it will be different from the profile link that I used and composed in the template. I will add a task for the header in issue tracking

@kwasniew kwasniew merged commit 6f09bcd into main Nov 4, 2024
11 checks passed
@kwasniew kwasniew deleted the unsubscribe-from-profile-settings branch November 4, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants