fix: prevent rendering too many hooks error #8667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
| const projectId = useRequiredPathParam('projectId'); | ||
| const { total } = useActionableChangeRequests(projectId); | ||
|
|
||
| const count = simplifyProjectOverview ? 0 : (total ?? 0); |
There was a problem hiding this comment.
Isn't if (!simplifyProjectOverview) return null; a better check? If the flag is off we don't add empty elements to the DOM.
There was a problem hiding this comment.
No, because if we return null, we won't render a label at all. This way, at least the label is the same, though we could potentially just use a different label
There was a problem hiding this comment.
Ok, I thought this was just the count. I'll go ahead and approve it then.
There was a problem hiding this comment.
But I found a nicer way to do it in ad7aa87. We'll just render the text. This makes it render exactly the same as all the other tabs do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue where we'd get a minified react error referencing the LazyProjectExport component.
We suspect that the issue might be the conditional rendering of this component, so the fix is to always render it, but to use the flag to check whether we should show the count or not.