chore: flag overview page redesign - environments #8683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
daveleek
reviewed
Nov 8, 2024
| @@ -40,6 +40,7 @@ describe('demo', () => { | |||
| res.body.flags = { | |||
| ...res.body.flags, | |||
| demo: true, | |||
| flagOverviewRedesign: true, | |||
There was a problem hiding this comment.
What's the implications of this?
There was a problem hiding this comment.
This makes the demo e2e tests, that we only run manually and rarely, use the new flag overview page redesign.
daveleek
reviewed
Nov 8, 2024
| @@ -227,7 +227,6 @@ export const deleteFeatureStrategy_UI = ( | |||
| }, | |||
| ).as('deleteUserStrategy'); | |||
| cy.visit(`/projects/${project}/features/${featureToggleName}`); | |||
| cy.get('[data-testid=FEATURE_ENVIRONMENT_ACCORDION_development]').click(); | |||
There was a problem hiding this comment.
Is this in combination with the demo.ts change of adding the feature flag that we enable the flag to do the test, so we are only testing the new UI and not the old UI?
There was a problem hiding this comment.
With this change we're only testing the new UI, not the old one. See: https://github.com/Unleash/unleash/pull/8683/files#diff-3c93375ad9f5acedec6fbc6c020d3927053759ee0b74bd129a1397e1e22ba81aR47
chriswk
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2826/enabling-environment-via-feature-flag-environment-section-header
https://linear.app/unleash/issue/2-2825/feature-flag-list-bottom-left-to-be-a-nav-section
Follow-up to: #8663
Implements most of the remaining work for our flag overview page redesign.
Most of the code you see is a straight copy/paste from our older existing components, with the slight improvement here and there.
Includes some improvements to our vertical tabs component to suit our use case.
Also updates the Demo flow accordingly. I did some manual tests and it seems to work decently in both scenarios, whether
flagOverviewRedesignis enabled or not. The demo needs some love but that's a story for a different PR and a different time.Once again, due to the duplicate file pattern, we should remember to clean this up if we decide to remove the flag.