Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics for password and scim enabled #8730

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 13, 2024

About the changes

Added metrics that tell us if SCIM and password auth are enabled.
It's similar to SAML and OIDC checks we had before. Not we have full picture so that we can check if instance has SSO enabled but password disabled.

Important files

Discussion points

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 8:51am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 8:51am

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

'unleash.auth.simple',
);

return settings?.disabled !== false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password auth has different logic than others (disable instead of enabled check)

@kwasniew kwasniew requested a review from ivarconr November 13, 2024 08:44
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit bb0403d into main Nov 13, 2024
9 of 11 checks passed
@kwasniew kwasniew deleted the metrics-password-scim-enabled-check branch November 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants