Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stale flags counter #8741

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Nov 13, 2024

This PR adds the stale flag component to the health grid. In doing so, it also reworks the layout of the health row (now a grid) and updates the health component.

In addition to removing the text from the component, I have adjust the SVG a bit to make it not shrink on smaller screens and have adjusted it's spacing, so that it's not full of dead space at the bottom. This makes it easier to style because it doesn't add 15px of invisible content.

This PR also touches up a few other visual issues I found, such as header level and sidebar width.

Wide:
image

Medium:
image

Narrow:
image

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 8:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 8:54am

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@thomasheartman thomasheartman changed the title [wip]: Add stale flags indicator feat: Add stale flags indicator Nov 14, 2024
@thomasheartman thomasheartman changed the title feat: Add stale flags indicator feat: Add stale flags counter Nov 14, 2024
@thomasheartman thomasheartman enabled auto-merge (squash) November 14, 2024 08:52
@thomasheartman thomasheartman merged commit 9440b52 into main Nov 14, 2024
11 checks passed
@thomasheartman thomasheartman deleted the 1-3107/add-stale-flags-component-UI branch November 14, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants