Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show deleted user sessions #8749

Merged
merged 10 commits into from
Nov 14, 2024
Merged

feat: show deleted user sessions #8749

merged 10 commits into from
Nov 14, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 14, 2024

About the changes

After log in we show a toast telling user that they were logged out of stale sessions

Screenshot 2024-11-14 at 10 11 20

Next steps:

  • add tests for toast

Important files

Discussion points

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 9:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 9:27am

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Math.max(allowedSessions - 1, 0),
);
user.deletedSessions = deletedSessionsCount;
user.activeSessions = allowedSessions;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tymek I'm using the field that you added to user schema

@@ -95,8 +115,9 @@ afterAll(async () => {
await db.destroy();
});

afterEach(async () => {
beforeEach(async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a better practice to clean data before not after since it allows debugging failed tests

@kwasniew kwasniew merged commit 4fabf49 into main Nov 14, 2024
12 checks passed
@kwasniew kwasniew deleted the show-deleted-sessions branch November 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants