feat: Change request applied diff for update strategy #8859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
changed the title
thomasheartman
approved these changes
Nov 26, 2024
kwasniew
commented
Nov 27, 2024
| @@ -1,5 +1,5 @@ | |||
| import type React from 'react'; | |||
| import type { VFC, FC, ReactNode } from 'react'; | |||
kwasniew
commented
Nov 27, 2024
| currentStrategy: IFeatureStrategy | undefined; | ||
| actions?: ReactNode; | ||
| }> = ({ change, changeRequestState, currentStrategy, actions }) => { | ||
| const name = |
There was a problem hiding this comment.
extracted DeleteStrategy component so that we can do the ifs checks outside of the inline calls
kwasniew
commented
Nov 27, 2024
| currentStrategy: IFeatureStrategy | undefined; | ||
| actions?: ReactNode; | ||
| }> = ({ change, changeRequestState, currentStrategy, actions }) => { | ||
| const hasVariantDiff = hasDiff( |
There was a problem hiding this comment.
extracted component can have display data calculation outside of the inline calls
kwasniew
commented
Nov 27, 2024
| @@ -185,139 +326,35 @@ export const StrategyChange: VFC<{ | |||
| <div>{actions}</div> | |||
| </ChangeItemCreateEditDeleteWrapper> | |||
| <StrategyExecution strategy={change.payload} /> | |||
| <ConditionallyRender | |||
| condition={hasVariantDiff} | |||
There was a problem hiding this comment.
for add strategy diff checking doesn't make sense
kwasniew
commented
Nov 27, 2024
| @@ -80,29 +78,32 @@ const Truncated = styled('div')(() => ({ | |||
| })); | |||
|
|
|||
| export const StrategyTooltipLink: FC<IStrategyTooltipLinkProps> = ({ | |||
| change, | |||
There was a problem hiding this comment.
this was unnecessary coupling
kwasniew
commented
Nov 27, 2024
| @@ -80,29 +78,32 @@ const Truncated = styled('div')(() => ({ | |||
| })); | |||
|
|
|||
| export const StrategyTooltipLink: FC<IStrategyTooltipLinkProps> = ({ | |||
| change, | |||
| name, | |||
There was a problem hiding this comment.
strategy name and title passing give us more flexibility in caller code (can select current live strategy vs snapshot depending on CR state)
kwasniew
commented
Nov 27, 2024
| }; | ||
|
|
||
| type ChangeRequestDeleteStrategy = { | ||
| id: string; | ||
| name: string; | ||
| name?: string; |
There was a problem hiding this comment.
for applied change requests this one is never provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Show correct title diff and payload diff (e.g. rollout %) when change request is applied
Previously we were always comparing title and payload against the current strategy. But after the strategy is applied there's no diff anymore. What's more when the strategy is updated in future we're diffing against a future value. This PR always looks at the snapshot for change request when the change request is applied.
I added tests showing both cases in detail.
There will be another PR in the backend to take a snapshot when the CR is being applied.
Also we should add snapshots for deleted strategies since so that we can show diffs for them after applying CRs.
Update: added delete strategies improvements and extract method refactor in this PR
Important files
Discussion points