Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove admonitions from Proxy docs #8860

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

melindafekete
Copy link
Collaborator

@melindafekete melindafekete commented Nov 26, 2024

This PR contains two small fixes:

  1. SSO Overview: remove Google Authentication from the list of supported providers in the intro, as it has been deprecated.
  2. Unleash Proxy generated docs: remove injected admonition containing tips. Proxy is now in maintenance mode, and we don't want other admonitions to distract from that message

Remove deprecated authentication provider from SSO intro
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 1:06pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 1:06pm

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@melindafekete melindafekete marked this pull request as ready for review November 27, 2024 18:01
@alvinometric alvinometric changed the title Remove adminitions from Proxy docs Remove admonitions from Proxy docs Nov 28, 2024
Copy link
Contributor

@alvinometric alvinometric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Looking for how to run the Unleash proxy? Check out the [_how to run the Unleash proxy_ guide](../how-to/how-to-run-the-unleash-proxy.mdx)!

:::`,
'unleash-proxy': ``,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we remove the key? Rather than set an empty value

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same thing, I left the keys in there so it would be easier to edit later if we need to inject some admonitions, but I can remove them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants