fix: permission button tooltip behavior #8882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
requested review from
gastonfournier,
daveleek,
sjaanus,
FredrikOseberg and
thomasheartman
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
approved these changes
Nov 28, 2024
nunogois
added a commit
that referenced
this pull request
Dec 5, 2024
Follow-up to #8882 The referenced PR caused an unintended behavior by making the button behave like a normal button would on certain parent containers. Previously, the span wrapper caused a side effect that restricted the button’s width, which we were relying on. By setting some initial styling properties, this PR should hopefully satisfy both use cases.   
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-3039/fix-the-tooltip-behavior-in-permission-buttons
Improves the tooltip behavior of our permission button component.
This is achieved by removing the extra
spanelement that is wrapping theButtoncomponent.Before
The tooltip is not correctly aligned with the button. The lower section of the button is not clickable.
After
The tooltip is correctly aligned with the button. Every visible part of the button is clickable.