Go tutorial 🐿️

[alvinometric]

And examples 😄

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 8:36pm
unleash-monorepo-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 8:36pm

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

[melindafekete]

Nice! 🚀 Left some suggestions to align with the style guide. Please use up-to-date screenshots 🙏 (also with better aspect ratio if possible). Let me know if you need help

[nnennandukwe]

I wonder if linking to the gradual rollout process or a/b testing would be good here.

[FredrikOseberg]

Apologies if I sound overly critical, I'm probably just missing some context. Some general feedback:

• Go code looks idiomatic
• Section using SDK looks good

I was having trouble understanding the first section of this PR where we provide examples on how to integrate with our API. There are a couple of reasons why:

• When I read feature flagging guide, unless it's made very clear, I assume that the guide is on consumption of feature flags.
• Language specific examples may be useful if you are writing a golang application that for some reason needs to manipulate the Admin API, but is this common? This is primarily something you would do via the Unleash UI. If I was going to automate this I would probably write bash scripts. It's typically not something you do from the application that consumes Unleash. I wonder if it just causing confusion?

[alvinometric]

Hey, thanks for the review @FredrikOseberg I said this in another comment but the Examples part is something we've been doing since the beginning and that is mostly for reference purposes.

It's so that people have easy blocks of code to copy-paste for various actions in their favourite languages. We've done this for every language we support so far.

That doesn't mean we have to continue doing it 😅 If you think these examples are counterproductive then we can talk about removing them

I removed all the problematic sections that you pointed out 🙏