fix: adjust favorite icon placement #8930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
commented
Dec 6, 2024
| @@ -30,7 +30,7 @@ export const FavoriteIconHeader: VFC<IFavoriteIconHeaderProps> = ({ | |||
| > | |||
| <IconButton | |||
| sx={{ | |||
| mx: -2.75, | |||
| mx: -0.75, | |||
kwasniew
commented
Dec 6, 2024
| @@ -5,8 +5,8 @@ import StarBorderIcon from '@mui/icons-material/StarBorder'; | |||
| import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender'; | |||
|
|
|||
| const StyledCell = styled(Box)(({ theme }) => ({ | |||
| paddingLeft: theme.spacing(0), | |||
| paddingRight: theme.spacing(1), | |||
| paddingLeft: theme.spacing(2), | |||
kwasniew
commented
Dec 6, 2024
| @@ -12,8 +12,7 @@ interface IRowSelectCellProps { | |||
| const StyledBoxCell = styled(Box)(({ theme }) => ({ | |||
| display: 'flex', | |||
| justifyContent: 'center', | |||
| paddingLeft: theme.spacing(1), | |||
| paddingRight: theme.spacing(0), | |||
| marginRight: theme.spacing(-2), | |||
There was a problem hiding this comment.
this will keep the project table compact while not affecting the search view
There was a problem hiding this comment.
tables have some default view that we can't get past so need a negative margin here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adjust search favorite icon placement
but the the project table compact
Important files
Discussion points