Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust favorite icon placement #8930

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: adjust favorite icon placement #8930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/component/common/Table/FavoriteIconHeader/FavoriteIconHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const FavoriteIconHeader: VFC<IFavoriteIconHeaderProps> = ({
>
<IconButton
sx={{
mx: -2.75,
mx: -0.75,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverts #8888

my: -1,
display: 'flex',
alignItems: 'center',
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/component/common/Table/cells/FavoriteIconCell/FavoriteIconCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import StarBorderIcon from '@mui/icons-material/StarBorder';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';

const StyledCell = styled(Box)(({ theme }) => ({
paddingLeft: theme.spacing(0),
paddingRight: theme.spacing(1),
paddingLeft: theme.spacing(2),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverts #8888

paddingRight: theme.spacing(0.5),
}));

const StyledIconButton = styled(IconButton)(({ theme }) => ({
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/component/project/Project/ProjectFeatureToggles/RowSelectCell/RowSelectCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ interface IRowSelectCellProps {
const StyledBoxCell = styled(Box)(({ theme }) => ({
display: 'flex',
justifyContent: 'center',
paddingLeft: theme.spacing(1),
paddingRight: theme.spacing(0),
marginRight: theme.spacing(-2),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will keep the project table compact while not affecting the search view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tables have some default view that we can't get past so need a negative margin here

}));

export const RowSelectCell: FC<IRowSelectCellProps> = ({
Expand Down
Loading