Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable docker version tag on main #8979

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

gastonfournier
Copy link
Contributor

Since we're releasing from main now...

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 11:52am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 11:52am

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure we're not pushing version, major.minor, major on every push to main. I see it says workflow_dispatch as event name, but maybe we should also check if we have a tag?

@gastonfournier
Copy link
Contributor Author

Just make sure we're not pushing version, major.minor, major on every push to main. I see it says workflow_dispatch as event name, but maybe we should also check if we have a tag?

We are using input.version to figure out if checking out the tag or main

- name: Checkout tag v${{ inputs.version }}
if: ${{ inputs.version != '' }}
uses: actions/checkout@v4
with:
ref: v${{ inputs.version }} # tag that should be created by the caller workflow
- name: Checkout
if: ${{ inputs.version == '' }}
uses: actions/checkout@v4

So I used the same here 374a4cf

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit 59828cf into main Dec 13, 2024
7 checks passed
@gastonfournier gastonfournier deleted the docker-version-tag-on-main branch December 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants