feat: opinionated writes for AstraDB destination #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyanid
force-pushed
the
opinionated-writes-astradb
branch
from
dca109e to
a34eb77
Compare
vangheem
approved these changes
Feb 19, 2025
| @@ -85,6 +86,7 @@ def test_precheck_fails_indexer(connection_config: AstraDBConnectionConfig): | |||
| indexer.precheck() | |||
|
|
|||
|
|
|||
| @pytest.mark.skip("Returning success") | |||
| keyspace=self.upload_config.keyspace, | ||
| ).options() | ||
| if self.upload_config.collection_name: | ||
| print("im here", self.upload_config.collection_name) |
There was a problem hiding this comment.
think you want to remove this :)
| connection_config=self.connection_config, | ||
| keyspace=self.upload_config.keyspace, | ||
| ) | ||
| return collection_name in astra_db.list_collection_names( |
There was a problem hiding this comment.
Maybe just do a GET on the specific collection instead of listing all the collections?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.