Move the dataclass storing MyTardis introspection information into the MyTardis client #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-uoa
changed the title
… conceptually, it is used to hold data we obtain from MyTardis about its own configuration, not for configuring the ingestion behaviour.
…nitions into the dataclass definition. Delete a redundant test fixture
andrew-uoa
force-pushed
the
IDS-831-move-introspection-config
branch
from
c9f009b to
c014646
Compare
JLoveUOA
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntrospectionConfig seems out of place in the
src.configmodule, as the other types there are used to set/adjust aspects of the ingestion behaviour, whereas IntrospectionConfig stores configuration obtained from MyTardis; it's effectively immutable from the perspective of the ingestion code.The changes are:
mytardis_client.response_dataand rename toMyTardisIntrospection.Overseerand into theMyTardisIntrospectiondataclass, as this is strongly tied to the structure of MyTardis responses, so probably belongs inmytardis_clientsomewhere