Adding caliper annotations #213
Conversation
There was a problem hiding this comment.
@tomdeakin @giordano August is a student working with the benchpark group, and has instrumented your code with Caliper for measurements. Please consider his PR, everything is guarded by ifdef so will not impact your normal workflow.
|
This looks good, although I think this is for the driver code on main? There is a big refactor done in develop so not going to be a small job to port this over. I'll change the target and see what the merge conflicts look like... |
|
If the merge is gnarly, it might be easier to add the code again to develop. Let me know if I should task the student to start over with develop, I don’t think this would be too difficult.
Thanks,
Olga
…___________________________________________________________________
Olga Pearce, Ph.D., ***@***.******@***.***>, http://people.llnl.gov/olga
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory
On Feb 8, 2025, at 5:44 AM, Tom Deakin ***@***.***> wrote:
This looks good, although I think this is for the driver code on main? There is a big refactor done in develop so not going to be a small job to port this over. I'll change the target and see what the merge conflicts look like...
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/UoB-HPC/BabelStream/pull/213*issuecomment-2645154225__;Iw!!G2kpM7uM-TzIFchu!zbD_YGsZ0aqL2eTqWqwkMxo2u7xUkvvwf54zyPXoikO8mXLoKXD7xxVKyw_vHGKq_esdDCP-aNpQZ-99RsbFby4FQQ$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AF2ERAS5QWFKRYGTMAE6HID2OXUYVAVCNFSM6AAAAABWEBCYFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBVGE2TIMRSGU__;!!G2kpM7uM-TzIFchu!zbD_YGsZ0aqL2eTqWqwkMxo2u7xUkvvwf54zyPXoikO8mXLoKXD7xxVKyw_vHGKq_esdDCP-aNpQZ-99RsY1k3eBgg$>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
merge conflicts are now resolved. Should be good to merge! |
@tomdeakin This PR now targets develop! Hopefully it is easier to merge. |
Adding caliper cmake option.
Caliper allows for performance analysis through source code annotations.
More info on caliper can be found here: https://software.llnl.gov/Caliper/