Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment 2 updated to use new dataset #105

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Assignment 2 updated to use new dataset #105

merged 2 commits into from
Sep 30, 2024

Conversation

danielrazavi
Copy link
Member

What changes are you trying to make? (e.g., Adding or removing code, refactoring existing code, adding reports)

  • Updated the dataset in Assignment 2 from the Diabetes dataset to the Auto MPG dataset.
  • Refactored data exploration, data splitting, model fitting, and evaluation code to align with the new dataset.
  • Revised assignment questions to better fit the Auto MPG dataset context.
  • Updated Markdown descriptions to reflect the new dataset and added new questions to keep the assignment fresh.

How were these changes tested?

  • Ran all cells and tested for errors, ensuring that each section worked as intended.
  • Verified that the training and testing data splits were correctly executed with appropriate shapes.
  • Evaluated model output metrics (e.g., RMSE) to ensure the logic and performance were aligned with the objectives of the assignment.

Checklist

  • I can confirm that my changes are working as intended.

juliagallucci
juliagallucci previously approved these changes Sep 28, 2024
Copy link
Collaborator

@HongleiXie HongleiXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the quick turnaround. I added a couple of comments for review:

  1. In Q2 (iii) What is the (implied) null hypothesis? What is the (implied) alternative hypothesis? -- I think we should remove this question or substitute it with another one since we don't cover hypothesis testing in this cohort (we did for last cohort)
  2. Just be consistent with the slides/notebooks shown in class about the language, can we change to RMSPE instead in Q4 - Model Evaluation?

@danielrazavi
Copy link
Member Author

  1. Yes
  2. Yes

Copy link
Collaborator

@HongleiXie HongleiXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the revision!

@danielrazavi danielrazavi merged commit 49c81cb into main Sep 30, 2024
1 check failed
@danielrazavi danielrazavi deleted the a2-update branch September 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants