Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for cohort 4 #95

Closed
wants to merge 9 commits into from
Closed

Changes for cohort 4 #95

wants to merge 9 commits into from

Conversation

HongleiXie
Copy link
Contributor

@HongleiXie HongleiXie commented Sep 23, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

  • Removed old markdown slides and assets to avoid confusion
  • Removed the old assignments while waiting for the modified assignments coming to avoid confusion
  • Added the intro markdown
  • Removed the unused data column and overwrite the 01_materials/notebooks/dataset/wdbc.csv file
  • Updated README file to reflect the new cohort changes

Checklist

  • I can confirm that my changes are working as intended

@danielrazavi
Copy link
Member

We're awaiting issues being addressed, and will be merging in with a hard deadline of September 23, 2024

@@ -1,7 +1,7 @@
# Technical Facilitator Playbook

## How do you interact with the repo?
The Technical Facilitator will deliver the content in the `/01_materials/slides` directory. You are encouraged to live code with participants during live sessions. Please ensure that live coding files are uploaded to a new directory called `/live_code` under `/04_cohort_three` in this repository using a new branch. Please open a pull request for it to be merged.
The Technical Facilitator will deliver the content in the `/01_materials/slides` directory. You are encouraged to live code with participants during live sessions. Please ensure that live coding files are uploaded to a new directory called `/live_code` under `/04_cohort_4` in this repository using a new branch. Please open a pull request for it to be merged.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're renaming 04_cohort_three to 04_this_cohort as to make it easier for future cohorts.

@@ -1,8 +1,8 @@
#!/bin/bash

# CONFIGURATION
folder_md="./markdown_slides"
folder_output="../01_materials/slides" # This will be used for both PDF and HTML
folder_md="01_materials/slides"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should remain "./markdown_slides" as that is where the markdown files are located.

- [Cross Validation - Basic Idea and Steps](./04_cohort_three/additional_resources/05_review_session_material/cross_validation_basic_idea_and_steps.pdf)
- [EMLT Tutorial](./04_cohort_three/additional_resources/05_review_session_material/emlt_tutorials.pdf) -->
- [Introduction to Statistical Learning with Python Documentation (ISLP)](https://islp.readthedocs.io/en/latest/index.html)
- Textbook: [Data Science: A First Introduction](https://python.datasciencebook.ca/index.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove the commented out resources as this was the request of @RohanAlexander when this decision was made.

Exercises and homework are **optional** additional resources for you to learn outside the live learning sessions. Only assignments are mandatory in order to successfully pass this module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no more "exercise" or "homework", just "slides" and "notebook", but yes the assignment part is correct.

@HongleiXie HongleiXie closed this Sep 24, 2024
Copy link
Member

@danielrazavi danielrazavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our latest edits have been merged in. Many of the issues addressed by this PR have already been resolved, and the remaining ones should also be merged into the main branch. We just need to verify this against the most recent changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants