SMESHR - Improve docs #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move scripts that use SMRF albedo into dedicated folder
The environment needs the cython package to successfully compile `topocalc`. Also fix an incorrect markdown sytnax in the README referencing this file
specify gdal versioning to avoid issues (e.g., missing libgdal-hdf5 and ligbdal-grib) add netCDF4
add more verbose usage statements and fix typo add echo statements for pattern troubleshooting
Pin version of numpy and python for topocalc. The library has not been revisited to support numpy > 2 and python > 3.10
Wrap an optional step to extract abledo values from raw MODIS matlab files in a function. This step is ideally performed once for the MODIS period of record and the outputs re-used for any basin. Keeping the logic to preseve how this script expects the MODIS inputs to be.
update for pre-extracted MODIS albedo geotiffs arranged by wy
extract extent, resolution, epsg designation and BASIN_DOMAIN variable as input to parallel call of modis_basin() for improved basin switching
jomey
commented
Aug 1, 2024
jomey
commented
Aug 1, 2024
The `-mergetime` operator now requires to group files within `[]` when specifying multiple files to merge. Error message: ``` Using two operators with variable input without using sub groups [] is not allowed ```
The initial development CDO version (2.05) and current (2.2) have settle differences when using the `mergetime` operator. Pinning the working solution with this to prevent future breakage.
actually fix parallel call and confirm within modis_basin(). un-reverse y coords in extent designation
This is needed to calculate shading through the `snobedo` package
… into smeshr/docs
add catch for existing 24.nc files to reduce re-run time, tweak for little animas test basin
fix wildcard filematching of DSWRF_IN files and generalize basin varnames
jomey
commented
Sep 26, 2024
and export BASIN_DOMAIN for parallel call
jomey
commented
Oct 2, 2024
jomey
commented
Oct 2, 2024
remove filepath delimiter dependency
jomey
commented
Oct 2, 2024
fix to ERROR 1: Writing through VRTSourcedRasterBand is not supported.
|
@jmichellehu - Should we try to merge this soon now that the baseline setup works across different people? |
|
Yeah, I think that's a good idea. I'll take a look today and ping you back.
…________________________________
From: Joachim Meyer ***@***.***>
Sent: Wednesday, October 16, 2024 8:43 AM
To: UofU-Cryosphere/isnoda ***@***.***>
Cc: Michelle Hu ***@***.***>; Mention ***@***.***>
Subject: Re: [UofU-Cryosphere/isnoda] SMESHR - Improve docs (PR #64)
@jmichellehu<https://github.com/jmichellehu> - Should we try to merge this soon now that the baseline setup works across different people?
Then have more PRs modifying/extending this?
—
Reply to this email directly, view it on GitHub<#64 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKLYILP5L57L43OECES6QK3Z32CS7AVCNFSM6AAAAABLUOXDMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGIYTQOJXGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Change variable ERW_DAY_MST to DAY_MST
Add temporary usage guidance and catch to ensure isnoda env is active
Simplify global directory variables based off of BASIN_SMESHR_DIR. Update output solar_albedo directory as contemporary of time decay directory. Add TOPO filepaths for convenience.
Copy the generic albedo script as a basin-specific script stored within basin SMESHR dir. Build in basin SMESHR dir creation. Enforce script runs from HRRR directory. Also update run directories to end on 30 September
Segment out TCDC, DSWRF, MODIS albedo, and net solar calculations and scripts
jmichellehu
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Heya @jomey the changes are looking good to me. The one remaining issue is about the README.md. Shall we merge, but tag for follow-up when scripts take their final form (i.e., direct people to using SMESHR preparation scripts to generate new net_solar and cloud_factor files)?
jomey
commented
Oct 18, 2024
jomey
commented
Oct 18, 2024
jomey
commented
Oct 18, 2024
jomey
commented
Oct 18, 2024
Sure, we can work on an updated README once the scripts have established. Ideally (and on the long haul) all this logic should get moved into SMRF |
remove echos from HRRR_PATTERN matching and hrrr_param_for_topo commands
Segment net solar preparations from output linkages in case of pre-existing products. Update SMESHR_DIR for group outputs. Add verbosity for conditional flag status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the documentation for using MODIS-STC with iSnobal