Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): make Nginx TCP port configurable #3

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

peknur
Copy link
Contributor

@peknur peknur commented Nov 23, 2023

This adds possibility to listen different TCP ports using NGINX_PORT environment variable. This is useful if you want to run multiple instances of this container inside one pod, e.g.:

spec:
  containers:
    - image: ghcr.io/upcloudltd/hello
      name: hello80
      env:
        - name: NGINX_PORT
          value: "80"
    - image: ghcr.io/upcloudltd/hello
      name: hello8080
      env:
        - name: NGINX_PORT
          value: "8080"
    - image: ghcr.io/upcloudltd/hello
      name: hello81
      env:
        - name: NGINX_PORT
          value: "81"

NGINX_PORT defaults to 80

@peknur peknur requested a review from kangasta November 23, 2023 08:25
@peknur peknur merged commit 60c638d into main Nov 23, 2023
1 check passed
@peknur peknur deleted the feat/configurable-tcp-port branch November 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants