Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): golangci-lint v1.61.0 compatibility #334

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Conversation

villevsv-upcloud
Copy link
Contributor

No description provided.

@villevsv-upcloud villevsv-upcloud requested a review from a team as a code owner September 20, 2024 10:40
internal/ui/list_layout.go Outdated Show resolved Hide resolved
"testing"
)

func TestConcatStringsSingleString(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looping through input, expected tuples and doing assert in a sub-test would also work, as all tests have the same check, but no big difference.

internal/ui/ui_test.go Outdated Show resolved Hide resolved
@kangasta kangasta merged commit 1a1a673 into main Oct 8, 2024
7 checks passed
@kangasta kangasta deleted the fix/linter-fixes branch October 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants