fix(service): run only single attach/detach operation simultaneously #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajmyyra
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run only single attach/detach operation simultaneously per node.
CSI attacher sidecar runs multiple goroutines (10 by default) that handle volume attachments and that will lead many
SERVER_STATE_ILLEGALerrors when driver tries to do those operations concurrently towards the same node. Those operations succeed eventually but those cause unnecessary load to backend and increased pod deployment times.This PR tries to solve that problem by using mutex lock per node when executing
ControllerPublishVolumeandControllerUnpublishVolumemethods.