[pull] master from Roblox:master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Add ability to increase logging level from the command line. Default to 'info' level. Add a log message explaining when a release version tag name isn't being used. Co-authored-by: oltrep <[email protected]>
In a previous refactor, foreman paths we changed and the tool cache file usage was missed. This fixes the issue and add unit tests to pin the behavior.
Include architecture name in macOS platform keywords Add arm64 foreman build
Minor improvements to docs that should help prevent folks from missing things. A bit of elaboration of a known pitfall with adding foreman binaries to the PATH when other installations are ahead of them.
Better elaboration for a common error where a foreman-managed tool is being used outside of a scope in which it's been defined as a tool dependency. Additionally, this tees up a 1.0.4 release.
Artifact selection uses an outer loop over all assets, and an inner loop over possible valid names. This means that it will pick the first asset that matches any valid names, instead of the best match for the earliest name in the list. The fix should just be to switch the loops!
Added section to the readme to address bad binary downloads resulting from using
Fix typo in the artifact upload path for aarch64 build Add cleanup of the x86 artifacts to ensure architectures are not mixed up * Force merging as the cla-bot seems confused, despite the PR author being on the allow list
StyLua recently started producing linux-aarch64 builds. Foreman does not correctly take into account the architecture on linux, and selects the linux-aarch64 build when linux-x86_64 should be used. This causes GitHub Actions CI to fail. We fix this by preferring a more explicit name in platform keywords for linux (depending on arch), and falling back to the generic one if nothing is found
StyLua produces macOS M1 binaries using the macos-aarch64 name, rather than macos-arm64. We add in macos-aarch64 as a platform keyword so it doesn't fall back to the Rosetta x86_64 binary
* Update changelog, bump version * Update sanpshot
* Accumulate errors while installing * Update tests * Add test * Update tests * Format * Update test to account for hash map iteration * Remove unused snapshot * Update snapshot * Update snapshot * Move add_self_alias into Ok * Use vector to accumulate errors * Improve error handling * Use BTreeMap for iteration * update snapshot * Refactor test with snapshot * Format code * Use filter_map * Simplify error handling * format * Remove actual downloads * Update end-to-end test * Catch error in e2e test * Fix naming
Some roblox internal tools host builds on artifactory rather than via GitHub/GitLab. This is the first step towards supporting artifactory as a target for binary releases. The auth format used will be standardized across several internal tools, so the schema is included for posterity and used to validate the example in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )